Add coreml quant recipes #13265
Open
Add coreml quant recipes #13265
+812
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
abhinaykukkadapu
requested review from
digantdesai,
mcr229,
shoumikhin and
cccclai
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13265
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated FailureAs of commit e33390f with merge base a84b3c9 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
abhinaykukkadapu
requested review from
kimishpatel and
metascroy
and removed request for
shoumikhin,
cccclai and
mcr229
metascroy
reviewed
Aug 11, 2025
metascroy
reviewed
Aug 11, 2025
metascroy
reviewed
Aug 11, 2025
metascroy
reviewed
Aug 11, 2025
metascroy
reviewed
Aug 11, 2025
metascroy
reviewed
Aug 11, 2025
metascroy
reviewed
Aug 11, 2025
| ) | ||
| elif recipe_type == CoreMLRecipeType.INT4_WEIGHT_ONLY_PER_GROUP: | ||
| group_size = kwargs.pop("group_size", 32) | ||
| return self._build_torchao_quantized_recipe( |
There was a problem hiding this comment.
What is the compute precision used in these quantization recipes?
There was a problem hiding this comment.
@metascroy It is FLOAT16, see _get_coreml_lowering_recipe function defaults.
metascroy
reviewed
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds coreml quant recipes after FP32/16 recipes added in #13121
Recipes added: